Hive: removed Iceberg props should be removed from HMS table props too #2252
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pvary
reviewed
Feb 18, 2021
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveTableOperations.java
Outdated
Show resolved
Hide resolved
aokolnychyi
reviewed
Feb 18, 2021
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveTableOperations.java
Outdated
Show resolved
Hide resolved
aokolnychyi
approved these changes
Feb 18, 2021
Contributor
aokolnychyi
left a comment
aokolnychyi
left a comment
There was a problem hiding this comment.
LGTM. Thanks, @marton-bod!
Collaborator
Author
|
Thanks for the review @aokolnychyi , @pvary ! |
coolderli
pushed a commit
to coolderli/iceberg
that referenced
this pull request
Apr 26, 2021
stevenzwu
pushed a commit
to stevenzwu/iceberg
that referenced
this pull request
Jul 28, 2021
stevenzwu
pushed a commit
to stevenzwu/iceberg
that referenced
this pull request
Jul 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing #2249